Update quiver trace API - #7945
Open
emilykl wants to merge 9 commits into
Open
Conversation
emilykl
force-pushed
the
update-quiver-api
branch
from
August 7, 2026 00:04
847fd88 to
66fd95f
Compare
emilykl
force-pushed
the
update-quiver-api
branch
from
August 7, 2026 14:05
66fd95f to
7c9f063
Compare
archmoj
reviewed
Aug 10, 2026
| @@ -0,0 +1 @@ | |||
| - Rename `quiver` trace attributes for clarity and consistency: `sizeref` -> `lengthfactor`, `sizemode` -> `lengthmode`, `anglemode` -> `uvref` [[#7945](https://github.com/plotly/plotly.js/issues/7945)] | |||
Contributor
There was a problem hiding this comment.
Hi @emilykl,
Since this feature is not released yet, I suggest you modify 7710_add.md log instead and mention this PR.
- Add `quiver` trace type to visualize vector fields using arrows [[#7710](https://github.com/plotly/plotly.js/pull/7710), [#7945
](https://github.com/plotly/plotly.js/pull/7945)], with thanks to @degzhaus for the contribution!
Contributor
There was a problem hiding this comment.
I agree with this suggestion.
camdecoster
reviewed
Aug 10, 2026
camdecoster
left a comment
camdecoster
left a comment
Contributor
There was a problem hiding this comment.
I left you a few suggestions. I like the new attribute names.
| @@ -0,0 +1 @@ | |||
| - Rename `quiver` trace attributes for clarity and consistency: `sizeref` -> `lengthfactor`, `sizemode` -> `lengthmode`, `anglemode` -> `uvref` [[#7945](https://github.com/plotly/plotly.js/issues/7945)] | |||
Contributor
There was a problem hiding this comment.
I agree with this suggestion.
Comment on lines
118
to
121
| // TODO: How to handle the case where there is just one point in a trace, | ||
| // or all points have the same x or y value? This will give a boxArea of 0. | ||
| // For now I'm going to just normalize to a vector of unit length (1) in that case, | ||
| // but that's not a great solution |
Contributor
There was a problem hiding this comment.
Can this comment be addressed?
Contributor
Author
There was a problem hiding this comment.
Addressed by 1315d07. I updated the point distance calculation to be more accurate, and as a bonus now it covers the case where all the points are in a horizontal or vertical line.
There's nothing we can do about the case where all points have the same x or y value; I think it's reasonable to just default to 1 in that case.
| } else { // uvref === 'paper' | ||
| // TODO: For now, just do the same thing as for uvref === 'data', but this is not correct. | ||
| // We actually need more sophisticated logic here, since this will give a bad result | ||
| // if the data aspect ratio is very different from the plot aspect ratio. |
Contributor
There was a problem hiding this comment.
Is there a follow up issue to track this?
Co-authored-by: Cameron DeCoster <cameron.decoster@gmail.com>
emilykl
force-pushed
the
update-quiver-api
branch
from
August 22, 2026 22:50
b46f29c to
1507db6
Compare
… case where all points are in a horizontal or vertical line
emilykl
force-pushed
the
update-quiver-api
branch
from
August 22, 2026 22:59
1507db6 to
1315d07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7944
Also:
arrowref(was'axis'which is not an accepted value; changed to'data')